[PATCH] D142001: [clang] Use FP options from AST for emitting code for casts

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 19 00:19:19 PST 2023


rjmccall added a comment.

Overall looks reasonable.  One question about testing.



================
Comment at: clang/test/CodeGen/X86/avx512dq-builtins-constrained.c:7
 
-// FIXME: Every instance of "fpexcept.maytrap" is wrong.
+// Any cases of "fpexcept.maytrap" in this test are clang bugs.
+
----------------
Can you use `FileCheck --implicit-check-not` to verify this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142001/new/

https://reviews.llvm.org/D142001



More information about the cfe-commits mailing list