[PATCH] D71734: [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches.

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai marked an inline comment as done.
vsapsai added a comment.

In D71734#4061228 <https://reviews.llvm.org/D71734#4061228>, @ChuanqiXu wrote:

> LGTM generally. It'd better to mention this in the `Potentially Breaking Changes` section of ReleaseNotes.

Thanks for all your efforts during the review! Mentioned the change in the release notes.



================
Comment at: clang/lib/AST/Decl.cpp:4714
   setIsRandomized(false);
+  RecordDeclBits.ODRHash = 0;
 }
----------------
ChuanqiXu wrote:
> nit: setODRHash(0) may be more consistent with above style.
You are right, changed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71734/new/

https://reviews.llvm.org/D71734