[PATCH] D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 18 19:48:55 PST 2023


bruno created this revision.
bruno added reviewers: ChuanqiXu, nridge, sammccall.
Herald added subscribers: hoy, modimo, wenlei.
Herald added a project: All.
bruno requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

D115187 <https://reviews.llvm.org/D115187> exposed CoroutineSuspendExpr's operand, which makes some nodes to show up twice during the traversal, confusing the check for unsequenced operations. Skip the operand since it's already handled as part of the common expression and get rid of the misleading warnings.

https://github.com/llvm/llvm-project/issues/56768


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142077

Files:
  clang/lib/Sema/SemaChecking.cpp
  clang/test/SemaCXX/warn-unsequenced-coro.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142077.490364.patch
Type: text/x-patch
Size: 5121 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230119/3b941d08/attachment.bin>


More information about the cfe-commits mailing list