[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 18 13:37:09 PST 2023


erichkeane updated this revision to Diff 490278.
erichkeane added a comment.

Added tests suggested by Tom, also moved the cast creation after checking of the return type, so that we end up not hitting hte assert that Tom came up with.  Added 2 tests that show the two conditions (that DID repro as a crash).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141954/new/

https://reviews.llvm.org/D141954

Files:
  clang/docs/ReleaseNotes.rst
  clang/lib/Sema/SemaConcept.cpp
  clang/test/CXX/temp/temp.constr/temp.constr.atomic/constrant-satisfaction-conversions.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141954.490278.patch
Type: text/x-patch
Size: 5540 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230118/32e73644/attachment.bin>


More information about the cfe-commits mailing list