[PATCH] D142028: [clang] remove SUBMODULE_TOPHEADER

[Richard Howell via Phabricator via cfe-commits]

rmaz added a comment.

In D142028#4062798 <https://reviews.llvm.org/D142028#4062798>, @akyrtzi wrote:

> Is it reasonable to at least have an alternative implementation for it (e.g. from the module headers find the headers that were not included from other headers), not sure if it'd be straightforward or not.

Its feasible to refactor by moving the `collectModuleHeaderIncludes` function to be a method on `Module` with a callback. Then we could avoid serializing the top header list and call the method in CIndex as well as FrontendAction. I'll take a look at how much work this is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142028/new/

https://reviews.llvm.org/D142028