[PATCH] D141772: [clang][Interp] Fix record initialization via CallExpr subclasses

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 18 10:16:58 PST 2023


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

> I think the patch itself is mostly obvious, but I was wondering if it is the right time to add such RUN lines to existing test cases like I do here for test/SemaCXX/constexpr-nqueens.cpp.

If the tests are (mostly) passing without a bunch of FIXME comments, then yes, I think it's a great step to start running more of these tests with both constant expression engines.

LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141772/new/

https://reviews.llvm.org/D141772



More information about the cfe-commits mailing list