[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5
    Saiyedul Islam via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Wed Jan 18 07:31:43 PST 2023
    
    
  
saiislam marked an inline comment as done.
saiislam added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7085
   if (Triple.isAMDGPU()) {
-    handleAMDGPUCodeObjectVersionOptions(D, Args, CmdArgs);
+    handleAMDGPUCodeObjectVersionOptions(D, C.getArgs(), CmdArgs,
+                                         /*IsCC1As=*/true);
----------------
yaxunl wrote:
> Any reason you need the original args? This will bypass the driver translation, which should not in normal cases.
We need derived args to look for mcode-object-version. I have created a separate review for this change. Please have a look at D142022
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139730/new/
https://reviews.llvm.org/D139730
    
    
More information about the cfe-commits
mailing list