[PATCH] D119708: [clang][lex] Remove `PPCallbacks::FileNotFound()`

Wed Jan 18 01:10:54 PST 2023

v.g.vassilev added a comment.

In D119708#4060336 <https://reviews.llvm.org/D119708#4060336>, @jansvoboda11 wrote:

> In D119708#4059254 <https://reviews.llvm.org/D119708#4059254>, @Hahnfeld wrote:
>
>> Hello, sorry for the late heads-up, but this functionality is used by ROOT: https://github.com/root-project/root/blob/f58cccf5ce7fd67894c7fd9e9e74d3f37bc1acba/core/metacling/src/TClingCallbacks.cxx#L282 Any chance of bringing this back?
>
> Hi. Your downstream callback never fills in `RecoveryPath` and always returns `false`, meaning it will never reach the unsafe block of code I had issue with: `HeaderInfo.AddSearchPath(DL, isAngled)`.
> Technically, we could bring back a safe/trimmed-down version of this callback that doesn't take the out-parameter and returns `void`. But I don't think it's the right call, since that would essentially re-introduce dead code to upstream.
> This is probably best kept downstream, unless there are other downstream users.

+1 for bringing back that piece of code because it seems an interesting event to listen to anyways. Would you be more comfortable if we provide also a test case and relevant comments explaining the use-case?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119708/new/

https://reviews.llvm.org/D119708