[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

Zixuan Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 17 22:04:43 PST 2023


zixuan-wu added a comment.

In D141899#4058173 <https://reviews.llvm.org/D141899#4058173>, @LuoYuanke wrote:

> @zixuan-wu, changing x86_amx would break our internal code. May I know the motivation to change the type?

The background is at https://reviews.llvm.org/D135202. No more motivation, just to purify LLVM IR and demonstrate target extension. I think putting target-specific type into LLVM IR was thoughtless at that moment. Considering there was no better solution at that time such as target extension, it's a workable workaround. But it should not keep going anymore if there is better way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141899/new/

https://reviews.llvm.org/D141899



More information about the cfe-commits mailing list