[PATCH] D141768: [11/15][Clang][RISCV][NFC] Remove Policy::PolicyType::Omit

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 17 16:43:40 PST 2023


craig.topper added inline comments.


================
Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:1032
+    if (IsMasked) {
+      if (PolicyAttrs.isTUMAPolicy() && !HasMaskPolicy)
+        appendPolicySuffix("_tum");
----------------
If you hadn't just removed Omit, it somewhat feels like Omit should be part of Policy and this code to pick the policy suffix string should be inside the Policy class. But I'll defer to your judgement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141768/new/

https://reviews.llvm.org/D141768



More information about the cfe-commits mailing list