[PATCH] D141574: [2/15][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 17 16:17:32 PST 2023


craig.topper added inline comments.


================
Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:96
 struct Policy {
-  bool PolicyNone = false;
+  bool IsUnspecified = false;
   enum PolicyType {
----------------
Maybe this should default to true, and the constructor that wants false should set it to false? Then you can use `= default` for the default constructor.


================
Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:921
+  if (PolicyAttrs.isUnspecified()) {
     if (!IsMasked) {
+      PolicyAttrs.IsUnspecified = false;
----------------
This can be folded into the previous if using `&&`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141574/new/

https://reviews.llvm.org/D141574



More information about the cfe-commits mailing list