[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

[Kevin P. Neal via Phabricator via cfe-commits]

kpn added inline comments.


================
Comment at: clang/test/CodeGen/complex-strictfp.c:8-9
 // Include rounding metadata in the testing.
-// FIXME: All cases of "fpexcept.maytrap" in this test are wrong.
-// FIXME: All cases of "round.tonearest" in this test are wrong.
+// All cases of "fpexcept.maytrap" in this test are wrong.
+// All cases of "round.tonearest" in this test are wrong.
 
----------------
arsenm wrote:
> So the tests are wrong but should no longer be fixed?
The tests were wrong and are now correct. He left the comment to tell the future that if either "fpexcept.maytrap" or "round.tonearest" reappear then it means a regression in clang.

How about changing "all' to "any"? And change "wrong" to "clang bugs"? As in 'Any cases of "fpexcept.maytrap" in this test are clang bugs.'?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141765/new/

https://reviews.llvm.org/D141765