[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

[Steven Wu via Phabricator via cfe-commits]

steven_wu added a comment.

In D141625#4060460 <https://reviews.llvm.org/D141625#4060460>, @dblaikie wrote:

> In D141625#4059486 <https://reviews.llvm.org/D141625#4059486>, @steven_wu wrote:
>
>> @dblaikie Do we have any bots running reverse iteration?
>
> Hmm, not that I can see/find at a quick glance, which is unfortunate. @mgrang Are you still working on LLVM/have any knowledge of reverse iteration testing being done? (@colinl - looks like maybe you're a Code Aurora person, perhaps you've got some more recent context for this?)

At another look, it is not very easy to write a test that checks a strict ordering of the serialization. The only tool I know that can dump the module is `llvm-bcanalyzer` but everything in the module will appear in the order of anonymous decl number order. You have to decode the Decls and Types to know if they actually appear in the source ordering. A diff test probably makes a lot more sense here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141625/new/

https://reviews.llvm.org/D141625