[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

[Nikolas Klauser via Phabricator via cfe-commits]

philnik added a comment.

In D141954#4060212 <https://reviews.llvm.org/D141954#4060212>, @erichkeane wrote:

> @ldionne @Mordante  The libcxx failure isn't clear what it is complaining about, but I thought this fix might end up breaking a libcxx test, since it would be easy to fall into the trap of having an implicit conversion here.
>
> Any chance you could prod at that test a little and see whose fault it is?
>
> ALSO: NOTE TO SELF: need release note!

I think the problem is that `__type_traits/common_reference.h` doesn't re-export `__type_traits/common_type.h` in the modulemap. It //should// be enough to add `export common_type` to `module common_reference` (`libcxx/include/module.modulemap.in:1399`). See `module is_arithmetic` for an example. This is just a guess though, this stuff can be very weird.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141954/new/

https://reviews.llvm.org/D141954