[PATCH] D133574: [C2x] reject type definitions in offsetof

Tue Jan 17 11:34:42 PST 2023

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

I've relanded this as f1f0a0d8e8fdd2e534d9423b2e64c6b8aaa53aee <https://reviews.llvm.org/rGf1f0a0d8e8fdd2e534d9423b2e64c6b8aaa53aee>, changes include:

- Removed error in C mode, turned it into an extension warning
- Added an extension warning for using member access or array subscript expressions for the member designator
- Corrected expected test output
- Added documentation

The new warnings are both under a new flag `-Wgnu-offsetof-extensions` which is nested under the `-Wgnu` flag.

Marking this review as accepted so I can close it now that I think it's completed again. However, if anyone spots further concerns, please raise them!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133574/new/

https://reviews.llvm.org/D133574