[PATCH] D140959: RFC: Multilib prototype

[Simon Tatham via Phabricator via cfe-commits]

simon_tatham added a comment.

"Make difficult things possible": perhaps it might be useful to make sure it's at least //possible// to express a complex boolean function of the basic predicates, even if it's cumbersome? (So that, for example, you could make an attribute conditional on "this cc1 option but not that one".) I assume YAML would let you write something like an expression AST in hierarchical form, with predicates like `regex:` at the leaves, and internal nodes for AND, OR and NOT.

Then again, perhaps it's enough to just make sure there's extension room in the syntax so that this can be added later, and there's no need to actually implement it in the first version.



================
Comment at: clang/test/Driver/Inputs/baremetal_multilib/arm-none-eabi/multilib.yaml:75
+  noMatchAttrs: [fpregs]
+- regex: -target-feature \+vfp2sp
+  matchAttrs: [vfp2sp]
----------------
Nit: don't forget to document whether these use basic or extended regex syntax


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140959/new/

https://reviews.llvm.org/D140959