[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 17 08:16:58 PST 2023


shafik added inline comments.


================
Comment at: clang/lib/Sema/SemaExprCXX.cpp:5387
+      return RD->canPassInRegisters();
+    return true;
   }
----------------
erichkeane wrote:
> Is there good reason to return true for all non-record types?  Should we instead be limiting the types that can make it this far?
Looking how it is used internally, I think it makes sense to restrict this to records. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141775/new/

https://reviews.llvm.org/D141775



More information about the cfe-commits mailing list