[clang-tools-extra] 2486c8d - [clangd] Disable modernize-macro-to-enum tidy check

Kadir Cetinkaya via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 17 08:12:16 PST 2023


Author: Kadir Cetinkaya
Date: 2023-01-17T17:12:07+01:00
New Revision: 2486c8d7bb377fccfc269472e59d748ece277c88

URL: https://github.com/llvm/llvm-project/commit/2486c8d7bb377fccfc269472e59d748ece277c88
DIFF: https://github.com/llvm/llvm-project/commit/2486c8d7bb377fccfc269472e59d748ece277c88.diff

LOG: [clangd] Disable modernize-macro-to-enum tidy check

Check relies on seeing PP-directives from preamble, hence it's unusable.
See https://github.com/clangd/clangd/issues/1464.

Added: 
    

Modified: 
    clang-tools-extra/clangd/TidyProvider.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/TidyProvider.cpp b/clang-tools-extra/clangd/TidyProvider.cpp
index 4adc5345c6d9f..f3ed6f08a9acb 100644
--- a/clang-tools-extra/clangd/TidyProvider.cpp
+++ b/clang-tools-extra/clangd/TidyProvider.cpp
@@ -205,7 +205,7 @@ TidyProvider disableUnusableChecks(llvm::ArrayRef<std::string> ExtraBadChecks) {
 
                        // Check relies on seeing ifndef/define/endif directives,
                        // clangd doesn't replay those when using a preamble.
-                       "-llvm-header-guard",
+                       "-llvm-header-guard", "-modernize-macro-to-enum",
 
                        // ----- Crashing Checks -----
 


        


More information about the cfe-commits mailing list