[PATCH] D141625: [DeclContext] Sort the Decls before adding into DeclContext

Tue Jan 17 08:02:25 PST 2023

dblaikie added a comment.

In D141625#4053067 <https://reviews.llvm.org/D141625#4053067>, @steven_wu wrote:

> @akyrtzi has the good idea. It is really hard to control `Decl*` to get values
> to get an unstable iteration order from the small tests, going beyond 32 decls
> to get out of SmallPtrSet's small model is much consistent.
>
> Add test.

Could you make a smaller test (probably just a couple of decls) that fails with LLVM_ENABLE_REVERSE_ITERATION? Such a failure would be more reliable/simpler to reproduce, probably?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141625/new/

https://reviews.llvm.org/D141625