[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Tue Jan 17 07:36:49 PST 2023

Michael137 added a comment.

In D141826#4058866 <https://reviews.llvm.org/D141826#4058866>, @erichkeane wrote:

> This seems innocuous enough/easy enough to use.  I'd like a comment on the functions at least and types in TemplateBase.h to specify that this is for printing-policy only?  Alternatively (and perhaps MUCH more appreciated) would be to make sure we mark the defaulted during AST generation as well.

I'll have a look at doing that

Are you suggesting we do the substitution check that the TypePrinter currently does when constructing the specialisation decls? So the TypePrinter simply needs to check the `TemplateArgument::getIsDefaulted`? I like the sound of that.

Unfortunately we'd still need the `setIsDefaulted` because of the DWARF limitation in LLDB

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141826/new/

https://reviews.llvm.org/D141826