[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

Tue Jan 17 05:55:42 PST 2023

LuoYuanke added a comment.

In D141899#4058683 <https://reviews.llvm.org/D141899#4058683>, @lebedev.ri wrote:

> In D141899#4058173 <https://reviews.llvm.org/D141899#4058173>, @LuoYuanke wrote:
>
>> @zixuan-wu, changing x86_amx would break our internal code. May I know the motivation to change the type?
>
> I just want to point out that generally "causes [too much] churn downstream"
> is not relevant concern upstream, as downstreams are considered to be on their own.

But we previously design the amx type and we follow the design to develop and maintain both the upsteam code and downstream code. I think we should respect the orginal author's effort for developing and maintaining the code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141899/new/

https://reviews.llvm.org/D141899