[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

Felipe de Azevedo Piovezan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 17 05:34:50 PST 2023


fdeazeve added a comment.

In D141381#4058327 <https://reviews.llvm.org/D141381#4058327>, @jmorse wrote:

> Curious -- that feels like the kind of thing we should be able to support, but adding more "special handling" to SROA isn't great.

Agreed! I'll have a look to see how far SROA is from being able to support this. Maybe it's almost there :)

> and if nothing optimises away the stack store

This is the part that concerns me a bit, since SROA removes the alloca+store because they have no uses other than the dbg.declare.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141381/new/

https://reviews.llvm.org/D141381



More information about the cfe-commits mailing list