[PATCH] D141838: [clang-tidy] fix a false positive of `cppcoreguidelines-avoid-non-const-global-variables`
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 16 08:23:38 PST 2023
njames93 added a comment.
I'm not convinced this is the correct fix.
The guildline <https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#i2-avoid-non-const-global-variables> states that tools should flag all variables declared at global or namespace scope.
Therefore we shouldn't be flagging any class static members, no matter if they are public, private or protected.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141838/new/
https://reviews.llvm.org/D141838
More information about the cfe-commits
mailing list