[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

[Sergei Barannikov via Phabricator via cfe-commits]

barannikov88 added a comment.

In D141581#4056503 <https://reviews.llvm.org/D141581#4056503>, @fpetrogalli wrote:

> This is because the sources of clangBasic and clangDriver might be compiled before LLVMTargetParser is ready.

...

> Therefore, if we say that clangDriver and clangBasic depend on LLVMTargetParser we make sure that the inclusion of the tablegen-generated file resolves correctly.

Sorry, I don't follow. If I read correctly, you're saying that clang libraries might begin to //compile// before their DEPENDS dependency is built (implying that DEPENDS clause only guarantees that the dependency is ready at //link// stage). If it is true, the proposed patch changes nothing -- the sources might still start to compile before cmake decides to generate inc file, because it is only needed at link stage.
Am I missing something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141581/new/

https://reviews.llvm.org/D141581