[PATCH] D141700: AMDGPU: Move enqueued block handling into clang
Juan Manuel Martinez CaamaƱo via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 16 01:21:08 PST 2023
jmmartinez added inline comments.
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:12581
+ Mod, HandleTy,
+ /*isConstant=*/true, llvm::GlobalValue::InternalLinkage,
+ /*Initializer=*/RuntimeHandleInitializer, RuntimeHandleName,
----------------
Just a cosmetical remark: Is there any reason to keep the `/*isConstant=*/`, `/*Initializer=*/`, ... comments? I think it would be better to avoid them.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141700/new/
https://reviews.llvm.org/D141700
More information about the cfe-commits
mailing list