[PATCH] D133574: [C2x] reject type definitions in offsetof
Florian Hahn via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 16 00:24:26 PST 2023
fhahn added a comment.
In D133574#4053647 <https://reviews.llvm.org/D133574#4053647>, @aaron.ballman wrote:
> I'll take care of fixing this up on Tuesday (Mon is a holiday here), but if anyone wants to get to it sooner, what I plan to do is:
>
> - Add a new `Extension` diagnostic about allowing you to define a type in `__builtin_offsetof`
> - Replace the error in C with the extension warning (C++ will continue to err)
> - Add documentation to the extensions manual for the builtin
> - Update the release note and tests accordingly
It might be worth to revert the patch in the meantime to reduce the impact on adopters that are using current `main` for testing. Among other things, it also breaks building the gcc workload or SPEC2017
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133574/new/
https://reviews.llvm.org/D133574
More information about the cfe-commits
mailing list