[PATCH] D141310: [clang] add -Wcompare-function-pointers

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 14 22:38:03 PST 2023


dblaikie added a comment.

@adriandole do you plan to deploy this in a codebase? Have you tried it on a codebase already?

I'd worry this would just be too noisy, and there's probably enough benign pointer comparisons that'll never hit the ICF false-equality situation (eg: putting some callbacks in a map/set/something - where the callbacks all do genuinely different things, so they'd never end up with accidental identical functions/folding) that it wouldn't be feasible to use this in a real codebase?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141310/new/

https://reviews.llvm.org/D141310



More information about the cfe-commits mailing list