[PATCH] D141769: [clang-tidy][NFC] Use C++17 nested namespaces in add_new_check.py and rename_check.py

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 14 09:48:26 PST 2023


Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/rename_check.py:311
       filename = fileRename(filename, old_module_path, new_module_path)
+      # TODO: remove below replacement when all clang-tidy checks have been
+      # updated with C++17 nested namespaces.
----------------
njames93 wrote:
> I'd argue the change to update all checks should go in at the same time.
`Clang-tidy` or just  `all checks`, since script is about Clang-tidy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141769/new/

https://reviews.llvm.org/D141769



More information about the cfe-commits mailing list