[PATCH] D141769: [clang-tidy][NFC] Use C++17 nested namespaces in add_new_check.py and rename_check.py

[Nathan James via Phabricator via cfe-commits]

njames93 accepted this revision.
njames93 added a comment.

LGTM, just a couple points



================
Comment at: clang-tools-extra/clang-tidy/rename_check.py:311-314
+      # TODO: remove below replacement when all clang-tidy checks have been
+      # updated with C++17 nested namespaces.
       replaceInFileRegex(filename, 'namespace ' + old_module + '[^ \n]*',
                          'namespace ' + new_namespace)
----------------
I'd argue the change to update all checks should go in at the same time.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:109-110
 
+- Use C++17 nested namespaces in `add_new_check.py` and `rename_check.py`.
+
 New checks
----------------
Such a trivial change like this probably doesn't need to go in the release notes, @Eugene.Zelenko thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141769/new/

https://reviews.llvm.org/D141769