[PATCH] D141681: [clang][Interp] Fix parameter map when re-visiting function

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 13 11:56:47 PST 2023


tbaeder added inline comments.


================
Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:57
+    ParamDescriptors.insert({ParamOffset, {Ty, Desc}});
+    Params.insert({PD, ParamOffset});
+    ParamOffset += align(primSize(Ty));
----------------
shafik wrote:
> Where is `Params` used?
In `ByteCodeExprGen.h` to emit `GetParam{,Ptr}` ops (which take the paramter offset as an argument).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141681/new/

https://reviews.llvm.org/D141681



More information about the cfe-commits mailing list