[PATCH] D141310: [clang] add -Wcompare-function-pointers

[Adrian Dole via Phabricator via cfe-commits]

adriandole added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticGroups.td:565
+def CompareFunctionPointers : DiagGroup<"compare-function-pointers">;
 def OrderedCompareFunctionPointers : DiagGroup<"ordered-compare-function-pointers">;
 def PackedNonPod : DiagGroup<"packed-non-pod">;
----------------
aaron.ballman wrote:
> Should `-Wcompare-function-pointers` enable `-Wordered-compare-function-pointers`? I think I would normally assume such a relationship as the ordered variant sounds like a subset of the unordered variant.
Makes sense, and it also fixes the issue of raising both this warning and `-Wordered-compare-function-pointers` on the same line. Will update.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141310/new/

https://reviews.llvm.org/D141310