[PATCH] D139949: [clang-scan-deps] Migrate to OptTable
Alex Brachet via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 13 10:12:49 PST 2023
abrachet marked 2 inline comments as done.
abrachet added inline comments.
================
Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:2207
":frontend",
+ ":ScanDepsTableGen",
":tooling",
----------------
GMNGeoffrey wrote:
> MaskRay wrote:
> > Move this before `:driver`
> Buildifier sorts these. Why does it need to be before driver? If it's really required, add a comment to prevent buildifier from sorting: http://go/buildifier#do-not-sort
> Move this before `:driver`
Done in commit
================
Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:2207
":frontend",
+ ":ScanDepsTableGen",
":tooling",
----------------
abrachet wrote:
> GMNGeoffrey wrote:
> > MaskRay wrote:
> > > Move this before `:driver`
> > Buildifier sorts these. Why does it need to be before driver? If it's really required, add a comment to prevent buildifier from sorting: http://go/buildifier#do-not-sort
> > Move this before `:driver`
>
> Done in commit
> Move this before `:driver`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139949/new/
https://reviews.llvm.org/D139949
More information about the cfe-commits
mailing list