[clang-tools-extra] e435f56 - [include-cleaner] Remove a stale FIXME.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 13 07:26:50 PST 2023


Author: Haojian Wu
Date: 2023-01-13T16:26:27+01:00
New Revision: e435f56815435422a63f5e9e9aad6959428e96c2

URL: https://github.com/llvm/llvm-project/commit/e435f56815435422a63f5e9e9aad6959428e96c2
DIFF: https://github.com/llvm/llvm-project/commit/e435f56815435422a63f5e9e9aad6959428e96c2.diff

LOG: [include-cleaner] Remove a stale FIXME.

This FIXME was addressed in 0e545816a9e582af29ea4b9441fea8ed376cf52a.

Added: 
    

Modified: 
    clang-tools-extra/include-cleaner/lib/WalkAST.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/include-cleaner/lib/WalkAST.cpp b/clang-tools-extra/include-cleaner/lib/WalkAST.cpp
index 6a5594e3d6d35..f317b0dc2d07b 100644
--- a/clang-tools-extra/include-cleaner/lib/WalkAST.cpp
+++ b/clang-tools-extra/include-cleaner/lib/WalkAST.cpp
@@ -91,8 +91,6 @@ class ASTWalker : public RecursiveASTVisitor<ASTWalker> {
     // usage of the base type of the MemberExpr, so that e.g. code
     // `returnFoo().bar` can keep #include "foo.h" (rather than inserting
     // "bar.h" for the underlying base type `Bar`).
-    //
-    // FIXME: support dependent types, e.g., "std::vector<T>().size()".
     QualType Type = E->getBase()->IgnoreImpCasts()->getType();
     report(E->getMemberLoc(), getMemberProvider(Type), RefType::Implicit);
     return true;


        


More information about the cfe-commits mailing list