[PATCH] D141670: [include-cleaner] FindHeaders respects IWYU export pragma for standard headers.

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:203
+                      const FileEntry *IncludedHeader,
+                      std::optional<tooling::stdlib::Header> StandardHeader) {
     if (ExportStack.empty())
----------------
kadircet wrote:
> just saying `StandardHeader` here isn't really useful. what about changing signautre here to take a `include_cleaner::Header` instead, named `IncludedHeader` and switch over kind to add it to ExportBy map? I don't think there's any value in storing Exporters for `<vector>` both as a physical entry and a stdlib entry.
Ah, nice idea! thanks.


================
Comment at: clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp:122
+  tooling::stdlib::Symbol StdString =
+      *tooling::stdlib::Symbol::named("std::", "string");
+  EXPECT_THAT(
----------------
kadircet wrote:
> nit: `tooling::stdlib::Header::named("<string>")`
We need this `tooling::stdlib::Symbol` here, `include_cleaner::findHeaders` accepts a `SymbolLocation`, `SymbolLocation` is construct from a `tooling::stdlib::Symbol`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141670/new/

https://reviews.llvm.org/D141670