[PATCH] D140547: Perform access checking to private members in simple requirement.

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a subscriber: aaron.ballman.
erichkeane added a comment.

In D140547#4050936 <https://reviews.llvm.org/D140547#4050936>, @ilya-biryukov wrote:

> In D140547#4050752 <https://reviews.llvm.org/D140547#4050752>, @uabelho wrote:
>
>> Anyone else see this?
>
> I have not checked, but I would not be surprised if we hit the stack size limits with asan enabled
> @usaxena95, maybe reduce the number of instantiations from `10001` to `1001` or `101`? It should not change the intention of the test and fix this failure.

This is a regression that was noticed by @aaron.ballman even without ASAN, so this is something that needs doing ASAP.  The branch is happening around the 24th, so this needs to be fixed by then.



================
Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1366
       LocalInstantiationScope Scope(SemaRef, /*CombineWithOuterScope=*/true);
-      return inherited::TransformRequiresExpr(E);
+      auto TransReq = inherited::TransformRequiresExpr(E);
+      if (TransReq.isInvalid())
----------------
'auto' isn't allowed here by coding standard, this needs to be ExprResult.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140547/new/

https://reviews.llvm.org/D140547