[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

Fri Jan 13 05:08:59 PST 2023

carlosgalvezp added a comment.

In D141133#4051068 <https://reviews.llvm.org/D141133#4051068>, @ccotter wrote:

> My latest update to the diff was the result of a rebase, then addressing the final comments. What I've been doing is something like
>
>   git pull upstream main --rebase
>   # make more edits
>   git commit -am ....
>   arc diff --update D141133 upstream/main
>
> I'm not sure if this is the best way to rebase phabs, but please let me know if there's a better way for phab to understand.

I just run `arc diff HEAD~` after rebase, and works just fine :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141133/new/

https://reviews.llvm.org/D141133