[PATCH] D140547: Perform access checking to private members in simple requirement.

[Mikael Holmén via Phabricator via cfe-commits]

uabelho added a comment.

Hi,

When I run the new testcase
 clang/test/SemaCXX/invalid-requirement-requires-expr.cpp
with ASAN binaries the test fails like

  FAIL: Clang :: SemaCXX/invalid-requirement-requires-expr.cpp (1 of 1)
  ******************** TEST 'Clang :: SemaCXX/invalid-requirement-requires-expr.cpp' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';   /repo/uabelho/main-github/llvm/build-all-bbisdk-asan/bin/clang -cc1 -internal-isystem /repo/uabelho/main-github/llvm/build-all-bbisdk-asan/lib/clang/16/include -nostdsysteminc /repo/uabelho/main-github/clang/test/SemaCXX/invalid-requirement-requires-expr.cpp -I/repo/uabelho/main-github/clang/test/SemaCXX -std=c++2a -verify
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  error: 'warning' diagnostics seen but not expected: 
    File /repo/uabelho/main-github/clang/test/SemaCXX/invalid-requirement-requires-expr.cpp Line 18: stack nearly exhausted; compilation time may suffer, and crashes due to stack overflow are likely
  error: 'note' diagnostics seen but not expected: 
    File /repo/uabelho/main-github/clang/test/SemaCXX/invalid-requirement-requires-expr.cpp Line 18: while checking the satisfaction of nested requirement requested here
    File /repo/uabelho/main-github/clang/test/SemaCXX/invalid-requirement-requires-expr.cpp Line 18: in instantiation of member function 'A<9660>::far' requested here
    File /repo/uabelho/main-github/clang/test/SemaCXX/invalid-requirement-requires-expr.cpp Line 18: while substituting template arguments into constraint expression here
    File /repo/uabelho/main-github/clang/test/SemaCXX/invalid-requirement-requires-expr.cpp Line 18: while checking the satisfaction of nested requirement requested here
    File /repo/uabelho/main-github/clang/test/SemaCXX/invalid-requirement-requires-expr.cpp Line 18: in instantiation of requirement here
    File /repo/uabelho/main-github/clang/test/SemaCXX/invalid-requirement-requires-expr.cpp Line 18: (skipping 1697 contexts in backtrace; use -ftemplate-backtrace-limit=0 to see all)
    File /repo/uabelho/main-github/clang/test/SemaCXX/invalid-requirement-requires-expr.cpp Line 18: while substituting template arguments into constraint expression here
    File /repo/uabelho/main-github/clang/test/SemaCXX/invalid-requirement-requires-expr.cpp Line 18: while checking the satisfaction of nested requirement requested here
    File /repo/uabelho/main-github/clang/test/SemaCXX/invalid-requirement-requires-expr.cpp Line 18: in instantiation of requirement here
    File /repo/uabelho/main-github/clang/test/SemaCXX/invalid-requirement-requires-expr.cpp Line 18: while checking the satisfaction of nested requirement requested here
    File /repo/uabelho/main-github/clang/test/SemaCXX/invalid-requirement-requires-expr.cpp Line 23: in instantiation of member function 'A<10001>::far' requested here
  12 errors generated.
  
  --
  
  ********************
  ********************
  Failed Tests (1):
    Clang :: SemaCXX/invalid-requirement-requires-expr.cpp
  
  
  Testing Time: 0.16s
    Failed: 1

Anyone else see this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140547/new/

https://reviews.llvm.org/D140547