[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

Thu Jan 12 23:46:21 PST 2023

pmatos added inline comments.

================
Comment at: clang/lib/AST/MicrosoftMangle.cpp:2479-2483
+#define WASM_REF_TYPE(InternalName, MangledName, Id, SingletonId, AS)          \
+  case BuiltinType::Id:                                                        \
+    Out << "PA";                                                               \
+    mangleArtificialTagType(TTK_Struct, MangledName);                          \
+    break;
----------------
aaron.ballman wrote:
> I don't think the `PA` bit is correct -- that seems to be specific to OpenCL. So I think that bit can simply be dropped, but CC @rnk for questions about Microsoft ABI.
OK, that makes sense. Although I got the feeling PA stood for Pointer or similar. Maybe @rnk can clarify. I will follow your suggestion for now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122215/new/

https://reviews.llvm.org/D122215