[PATCH] D141450: [Clang][cc1] Add -fno-modules-local-submodule-visibility to override the default

Thu Jan 12 16:07:34 PST 2023

Bigcheese added a comment.

In D141450#4044680 <https://reviews.llvm.org/D141450#4044680>, @dblaikie wrote:

>> This is a problem because some existing ObjectiveC code is not compatible with LSV
>
> Hmm, how is that true? Does this code only build with Clang Header Modules enabled, and can't build without that? (if it could build without it, I don't know why it'd need LSV, if I'm understanding all these things correctly... )

It only builds without modules or without LSV. The code either relies on incidental header inclusion at the top level, or in other cases there are bugs with ObjC categories and protocols in LSV mode. I'm about to update this patch to actually switch the default to no LSV for ObjC because of how big the issue is. Most ObjC code won't actually work in LSV mode.

We'd like to eventually fix this, but for now it's just not useful, and the previous default for ObjC++ was no LSV.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141450/new/

https://reviews.llvm.org/D141450