[PATCH] D141620: clang/OpenCL: Make enqueued blocks inherit the parent attributes
Matt Arsenault via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 12 14:43:37 PST 2023
arsenm added inline comments.
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:12488
+ // FIXME: The invoke isn't applying the right attributes either
+ llvm::AttrBuilder KernelAttrs(C, CGF.CurFn->getAttributes().getFnAttrs());
+ KernelAttrs.addAttribute("enqueued-block");
----------------
yaxunl wrote:
> The kernel should inherit attributes from the parent function since the parent may have function attributes explicitly specified for itself only. The kernel should take the default function attributes.
I was specifically try to get those, e.g. the attribute(target) example. Is there some way to specify attributes directly on a block?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141620/new/
https://reviews.llvm.org/D141620
More information about the cfe-commits
mailing list