[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

[Shafik Yaghmour via Phabricator via cfe-commits]

shafik added inline comments.


================
Comment at: clang/lib/Sema/SemaInit.cpp:10277-10281
+      AddTemplateOverloadCandidate(TD, FoundDecl, /*ExplicitArgs*/ nullptr,
+                                   TmpInits, Candidates,
+                                   SuppressUserConversions,
+                                   /*PartialOverloading*/ false, AllowExplicit,
+                                   ADLCallKind::NotADL, {}, true);
----------------
Minor issues, we need to match the format expected by [bugprone-comment](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html)


================
Comment at: clang/lib/Sema/SemaOverload.cpp:7341
       PartialOverloading, AllowExplicit,
-      /*AllowExplicitConversions*/ false, IsADLCandidate, Conversions, PO);
+      /*AllowExplicitConversions*/ false, IsADLCandidate, Conversions, PO,
+      Info.AggregateDeductionCandidateHasMismatchedArity);
----------------
formatting fix again.


================
Comment at: clang/lib/Sema/SemaTemplate.cpp:2587
+  // guides, turn off pack expansion for everything we're about to do.
+  ArgumentPackSubstitutionIndexRAII SubstIndex(*this, -1);
+  // Create a template instantiation record to track the "instantiation" of
----------------
formatting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139837/new/

https://reviews.llvm.org/D139837