[PATCH] D141558: [MemProf] Collect access density statistics during profiling

[Snehasish Kumar via Phabricator via cfe-commits]

snehasish added a comment.

Thanks for updating the tests.



================
Comment at: llvm/include/llvm/ProfileData/MemProfData.inc:35
 // The version number of the raw binary format.
 #define MEMPROF_RAW_VERSION 1ULL
 
----------------
Can you increment the version here? Then we won't accidentally read the old data with the new reader which expects more data per MemInfoBlock.

Also update the other copy of MemProfData.inc.


================
Comment at: llvm/test/tools/llvm-profdata/memprof-multi.test:44
 CHECK-NEXT:    Version: 1
-CHECK-NEXT:    NumSegments: 9
+CHECK-NEXT:    NumSegments: 7
 CHECK-NEXT:    NumMibInfo: 2
----------------
Use the same regex for NumSegments here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141558/new/

https://reviews.llvm.org/D141558