[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added inline comments.


================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:531-537
+  CmdArgs.push_back(*ClangPath);
+  CmdArgs.push_back("-o");
+  CmdArgs.push_back(*TempFileOrErr);
+  CmdArgs.push_back("-fPIC");
+  CmdArgs.push_back("-c");
+  CmdArgs.push_back(Args.MakeArgString("--target=" + Triple.getTriple()));
+  CmdArgs.push_back(Args.MakeArgString("-" + OptLevel));
----------------
jhuber6 wrote:
> arsenm wrote:
> > can use initializer list?
> Probably could, this is the same style we use in `Clang.cpp` so I usually end up using it.
well Clang.cpp is old, should move towards doing not old things


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141543/new/

https://reviews.llvm.org/D141543