[PATCH] D131858: [clang] Track the templated entity in type substitution.

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 12 08:44:08 PST 2023


erichkeane added a comment.

In D131858#4047799 <https://reviews.llvm.org/D131858#4047799>, @v.g.vassilev wrote:

> In D131858#4047785 <https://reviews.llvm.org/D131858#4047785>, @erichkeane wrote:
>
>> @mizvekov : I'm looking at the revert of this since no work seems to have been done to fix @steven_wu 's problem.  Unfortunately, it seems that reverting this requires reverting https://reviews.llvm.org/D134604 plus all of the "Instantiate" patches, which undoes basically all of your work.
>>
>> I'm starting it now, but its unfortunate that we are going to lose this much of your work.
>
> That is *really* unfortunate. @mizvekov (@erichkeane) is there any other way out here?

@mizvekov said he was working on fixing the issue, and we gave him a deadline of Tomorrow for it.  If he (or someone else) manages to fix the problem by Tuesday early AM PT, I won't have to do that.  BUT we cannot release with this regression.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131858/new/

https://reviews.llvm.org/D131858



More information about the cfe-commits mailing list