[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

[Nikolas Klauser via Phabricator via cfe-commits]

philnik added a comment.

In D141572#4047428 <https://reviews.llvm.org/D141572#4047428>, @aaron.ballman wrote:

> Thank you for working on this! I think the Debian CI failure is unrelated, but the libc++ one looks plausibly related:
>
>   /home/libcxx-builder/.buildkite-agent/builds/e6f11fd202bc-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1/module.modulemap:773:10: error: module 'std.coroutine' requires feature 'coroutines'
>     module coroutine {
>            ^
>   /home/libcxx-builder/.buildkite-agent/builds/e6f11fd202bc-1/llvm-project/libcxx-ci/libcxx/test/libcxx/modules_include.sh.cpp:158:10: note: submodule of top-level module 'std' implicitly imported here
>   #include <coroutine>
>            ^
>   1 error generated.
>
> adding the libc++ reviewers for awareness.

Yes, this is related. It should be enough to add `"coroutine": "(defined(__cpp_impl_coroutine) && __cpp_impl_coroutine >= 201902L) || (defined(__cpp_coroutines) && __cpp_coroutines >= 201703L)"` to `libcxx/utils/generate_header_tests.py` and run `ninja libcxx-generate-files`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141572/new/

https://reviews.llvm.org/D141572