[PATCH] D141509: [include-mapping] Fix parsing of html_book_20190607.zip (https://en.cppreference.com/w/File:html_book_20190607.zip). Skip entries that have been added to the index (C++20 symbols), but the corresponding pages for which have not been created yet.

Viktoriia Bakalova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 12 01:40:36 PST 2023


VitaNuo updated this revision to Diff 488539.
VitaNuo added a comment.

Address review comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141509/new/

https://reviews.llvm.org/D141509

Files:
  clang/tools/include-mapping/cppreference_parser.py


Index: clang/tools/include-mapping/cppreference_parser.py
===================================================================
--- clang/tools/include-mapping/cppreference_parser.py
+++ clang/tools/include-mapping/cppreference_parser.py
@@ -142,7 +142,8 @@
       if variant and variant not in variants_for_symbol:
         continue
       path = os.path.join(root_dir, symbol_page_path)
-      results.append((symbol_name,
+      if os.path.isfile(path):
+        results.append((symbol_name,
                       pool.apply_async(_ReadSymbolPage, (path, symbol_name))))
 
     # Build map from symbol name to a set of headers.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141509.488539.patch
Type: text/x-patch
Size: 630 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230112/aa32abe4/attachment.bin>


More information about the cfe-commits mailing list