[PATCH] D141437: [HIP] Use .hipi as preprocessor output extension

Wed Jan 11 20:33:08 PST 2023

[AMD Official Use Only - General]

Fixed by 503e02e861662ef84940fdc05e26c12fc0fca7f3. Thanks.

Sam

-----Original Message-----
From: Nico Weber via Phabricator <reviews at reviews.llvm.org>
Sent: Wednesday, January 11, 2023 11:25 PM
To: Liu, Yaxun (Sam) <Yaxun.Liu at amd.com>; tra at google.com
Cc: thakis at chromium.org; maskray at google.com; cfe-commits at lists.llvm.org; 473750510 at qq.com; tuliom at redhat.com; yronglin777 at gmail.com; Kumar N, Bhuvanendra <Bhuvanendra.KumarN at amd.com>; 1135831309 at qq.com; gandhi21299 at gmail.com; tbaeder at redhat.com; mlekena at skidmore.edu; blitzrakete at gmail.com; shenhan at google.com
Subject: [PATCH] D141437: [HIP] Use .hipi as preprocessor output extension

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

thakis added a comment.

I think this breaks tests on Windows: https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2F45.33.8.238%2Fwin%2F73191%2Fstep_7.txt&data=05%7C01%7Cyaxun.liu%40amd.com%7C13de06bdc38e49edd6f308daf4550754%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638090943311573611%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JihDs%2FYNuK5FqlQnlpeH6HHfMuVykklmOg0MgUbJ4A8%3D&reserved=0

Please take a look and revert for now if it takes a while to fix.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD141437%2Fnew%2F&data=05%7C01%7Cyaxun.liu%40amd.com%7C13de06bdc38e49edd6f308daf4550754%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638090943311573611%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=36LDFan8FQ%2BnroFc8LAaN5dJENQeMvb6eytkNaRHzps%3D&reserved=0

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD141437&data=05%7C01%7Cyaxun.liu%40amd.com%7C13de06bdc38e49edd6f308daf4550754%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638090943311573611%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=J4SCWar%2BKIF2eMoXtxHz1LSrgoxCU7NoPCBmQFxVg7U%3D&reserved=0