[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 11 18:04:37 PST 2023


ChuanqiXu added a comment.

In D140867#4043763 <https://reviews.llvm.org/D140867#4043763>, @Jake-Egan wrote:

> In D140867#4042405 <https://reviews.llvm.org/D140867#4042405>, @ChuanqiXu wrote:
>
>> In D140867#4042351 <https://reviews.llvm.org/D140867#4042351>, @Jake-Egan wrote:
>>
>>>> Would you like to take a double look?
>>>
>>> Yes, it still fails on the bot and on my local machine. I've added an XFAIL to the test for now just to get the AIX bot green.
>>
>> Weird. Maybe you can find a method by adding `REQUIRES` or `NOT-SUPPORTED` and test it locally. If it goes well then you can upstream the change.
>
> It seems that it's because the test fails when running on AIX - not just when it's being targeted.
>
>   // REQUIRES: x86-registered-target,aarch64-registered-target
>
> The above doesn't stop the test from being run on AIX. So, I can add:
>
>   // UNSUPPORTED: system-aix
>
> But do you want to keep the REQUIRES for other targets?

The `REQUIRES` are added for `AIX`, so maybe it is ok to abandon them temporarily and add them back once we find other similar failures.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140867/new/

https://reviews.llvm.org/D140867



More information about the cfe-commits mailing list