[PATCH] D141310: [clang] add -Wcompare-function-pointers

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

I have some notes about `--icf={safe,all}`: https://maskray.me/blog/2020-11-15-explain-gnu-linker-options#icfall-and---icfsafe

I think this diagnostic has some value (and I appreciate that it can be implemented so little code!). Some `--icf=all` issues like using function addresses as map keys cannot be detected, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141310/new/

https://reviews.llvm.org/D141310