[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

Wed Jan 11 13:10:57 PST 2023

dblaikie added a comment.

In D141381#4043985 <https://reviews.llvm.org/D141381#4043985>, @fdeazeve wrote:

> In D141381#4040639 <https://reviews.llvm.org/D141381#4040639>, @probinson wrote:
>
>> To get data about the code size impact, people typically build some large codebase with/without their patch and compare the .text sizes. It's common to use clang itself for this experiment.
>
> I ran a couple of experiments (*), running `objdump --section-headers build/bin/clang | grep text`:
>
> Debug without patch:   178,707,948 bytes
> Debug with patch:      178,785,896 bytes (+0.04%)

That does sound rather promising...

I'm guessing if we're going to add this generically for -O0 it's probably worth a thread on discourse for broader visibility.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141381/new/

https://reviews.llvm.org/D141381